ably/realtime/connectionmanager.py (1)

99-109: Consider handling mismatched lengths between completed messages and results.

Using zip_longest ensures all completed messages are processed even when res_list is shorter or empty. However, if res_list is longer than completed_messages, msg will be None for the extra items, which could cause an AttributeError when accessing msg.future.

♻️ Suggested fix to guard against None msg

                 # Default res to empty list if None
                 res_list = res if res is not None else []
                 for (msg, publish_result) in zip_longest(completed_messages, res_list):
+                    if msg is None:
+                        continue
                     if msg.future and not msg.future.done():
                         if err:
                             msg.future.set_exception(err)

ably/realtime/realtime_channel.py (1)

964-981: Potential ambiguity when both options and kwargs are provided.

The current logic converts kwargs to ChannelOptions only when options is None. If a user accidentally provides both options and kwargs, the kwargs will be silently ignored. Consider raising an error or warning in this case.

♻️ Suggested fix to warn about ignored kwargs

         # Convert kwargs to ChannelOptions if provided
         if kwargs and not options:
             options = ChannelOptions(**kwargs)
+        elif kwargs and options:
+            log.warning("Channels.get(): kwargs ignored when options is provided")
         elif options and isinstance(options, dict):
             options = ChannelOptions.from_dict(options)

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

test/ably/realtime/realtimechannelmutablemessages_test.py (1)

182-191: The channel.publish(messages=messages) call is incorrect.

The publish method only processes positional arguments via len(args). Calling with messages=messages as a keyword argument will result in an empty args tuple, causing a ValueError.

🔧 Suggested fix

-        result = await channel.publish(messages=messages)
+        result = await channel.publish(messages)

test/ably/realtime/realtimechannelmutablemessages_test.py (1)

182-189: publish(messages=messages) will raise; pass list positionally instead.

publish() only inspects *args, so kwargs are ignored and cause a ValueError.

🛠️ Suggested fix

-        result = await channel.publish(messages=messages)
+        result = await channel.publish(messages)

ably/realtime/connectionmanager.py (1)

216-223: Update the docstring return type.

send_protocol_message now returns PublishResult | None, but the docstring still states None.

ably/realtime/connectionmanager.py (1)

99-109: zip_longest can still produce msg=None when res_list is longer.

The previous review flagged this issue. While the server should not send more results than messages, defensive coding would prevent a potential AttributeError if it does. The suggested fix was to iterate over completed_messages and index into res_list:

🛠️ Suggested defensive fix

-                res_list = res if res is not None else []
-                for (msg, publish_result) in zip_longest(completed_messages, res_list):
+                res_list = res or []
+                for idx, msg in enumerate(completed_messages):
+                    publish_result = res_list[idx] if idx < len(res_list) else None
                     if msg.future and not msg.future.done():

test/ably/realtime/realtimechannelmutablemessages_test.py (2)

2-2: Consider using built-in list instead of typing.List.

Python 3.9+ supports using list directly in type annotations. The List import from typing is unnecessary if the project targets Python 3.9+.

📝 Suggested fix

 import logging
-from typing import List
 
 import pytest

And at line 281:

-        versions: List[Message] = []
+        versions: list[Message] = []

---

266-278: Consider catching specific exceptions in helper method.

The bare except Exception at line 273 catches all exceptions, which could mask unexpected errors during testing. Consider catching the specific exceptions expected (e.g., AblyException for not-found cases).

📝 Suggested fix

         async def check_message_action():
             nonlocal message
             try:
                 message = await channel.get_message(serial)
                 return message.action == action
-            except Exception:
+            except AblyException:
                 return False